Opened 12 years ago

Closed 11 years ago

#5895 closed defect (fixed)

BorderContainer: doesn't handle margins (IE/quirks?)

Reported by: Douglas Hays Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Run dijit/themes/themetester.html in IE6.
Using dijit revision [12149], everything looks OK.
Updating to revision [12153], the "Editable Text" panel has a vertical scrollbar that is almost completely obscured.

IE6 screenshot

Attachments (1)

5895.jpg (115.0 KB) - added by Douglas Hays 12 years ago.
IE6 screenshot

Download all attachments as: .zip

Change History (16)

Changed 12 years ago by Douglas Hays

Attachment: 5895.jpg added

IE6 screenshot

comment:1 Changed 12 years ago by Adam Peller

I believe it's a marginbox/borderbox/quirks mode issue with the new BorderContainer? code, related to the setting of margin on the page. We still don't seem to have the box model stuff all worked out.

comment:2 Changed 12 years ago by bill

Notes from #dojo chat: the margin is on "mainSplit", not on <body> itself. Thus it's a BorderContainer? issue. We don't need to fix this bug for 1.1 but should at least work around it on themeTester by using padding on "main" rather than margin on "mainSplit".

comment:3 Changed 12 years ago by Adam Peller

(In [12643]) Set margin on document, not BorderContainer. Refs #5895

comment:4 Changed 12 years ago by bill

Note that this seems to have regressed some. On Safari, http://download.dojotoolkit.org/release-1.1b1/dojo-release-1.1b1/dijit/themes/themeTester.html looks OK but http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html has the scrollbars.

There's also some problems when initially drawing (the CSS race condition), but even after resizing the window the nightly has unwanted scroll bars.

comment:5 Changed 12 years ago by Adam Peller

(In [12816]) revert [12643]. Refs #5895

comment:6 Changed 12 years ago by Adam Peller

(In [12854]) Workaround to avoid margin box problem in test, refs #5895

comment:7 Changed 12 years ago by Adam Peller

Milestone: 1.11.2

comment:8 Changed 12 years ago by bill

Description: modified (diff)
Milestone: 1.21.1
Owner: changed from Adam Peller to bill
Status: newassigned

comment:9 Changed 12 years ago by bill

Fixed in [13065].

comment:10 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

comment:11 Changed 12 years ago by Adam Peller

it's not really fixed... do we open another ticket to support margins?

comment:12 Changed 12 years ago by bill

Milestone: 1.11.2
Summary: IE6: themetester.html scrollbar is obscuredBorderContainer: doesn't handle margins

Oops, OK I misunderstood the ticket. Reopening (and changing the summary)

comment:13 Changed 12 years ago by Adam Peller

Summary: BorderContainer: doesn't handle marginsBorderContainer: doesn't handle margins (IE/quirks?)

comment:14 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

comment:15 Changed 11 years ago by bill

Description: modified (diff)
Resolution: fixed
Status: reopenedclosed

We've done a lot of refactoring for BorderContainer and fixed this along the way.

Note: See TracTickets for help on using tickets.