#5854 closed enhancement (fixed)
[patch][cla]Add option in dijit.form.DropDownButton to open dropDown above and not only below
Reported by: | Alessandro Ferrari | Owned by: | haysmark |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit - Form | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Attached patch add option in dijit.form.DropDownButton? to open dropDown above and not only below, but arrow should be reversed in "above" case and this isn't in the patch.
Attachments (3)
Change History (16)
comment:1 follow-up: 2 Changed 14 years ago by
Changed 14 years ago by
Attachment: | DropDownButtonCanOpenAbove.patch added |
---|
Provided by Alessandro Ferrari
comment:3 follow-up: 4 Changed 14 years ago by
Milestone: | → 1.2 |
---|---|
Reporter: | changed from guest to Alessandro Ferrari |
Great, thanks.
comment:5 Changed 14 years ago by
Summary: | Add option in dijit.form.DropDownButton to open dropDown above and not only below → [patch][cla]Add option in dijit.form.DropDownButton to open dropDown above and not only below |
---|
comment:6 Changed 14 years ago by
Milestone: | 1.2 → 1.3 |
---|---|
Owner: | set to haysmark |
Deferring since the patch doesn't change the arrow direction.
comment:7 Changed 14 years ago by
Milestone: | 1.3 → 1.4 |
---|
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4
Changed 13 years ago by
Attachment: | 5854.patch added |
---|
Refs #5854. Added position attribute to DropDownButton?. Refactor popup positioning code in Tooltip to dijit.getPopupAroundAlignment(). Removed TODO in DropDownButton? by adding call to dijit.getPopupAroundAlignment().
Changed 13 years ago by
Attachment: | 5854.2.patch added |
---|
Refs #5854. Added position attribute to _hasDropDown. Refactor popup positioning code in Tooltip to dijit.getPopupAroundAlignment(). Removed TODO in _hasDropDown by adding call to dijit.getPopupAroundAlignment().
comment:8 Changed 13 years ago by
All of the drop down code the original patch references has been refactored to _hasDropDown, I attached a patch for the refactor.
comment:9 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [19513]) Add option for widgets with drop downs (in particular DropDownButton? and ComboButton?) to open dropDown above and not only below, or even to the left or right.
I'd still like to add CSS classes and icons to control which arrow icon shows up though. Fixes #5854 !strict
Patch from Mark Hays (IBM, CCLA on file)
comment:10 Changed 13 years ago by
comment:11 Changed 13 years ago by
comment:12 Changed 12 years ago by
comment:13 Changed 11 years ago by
Component: | Dijit → Dijit - Form |
---|
could you identify yourself please, and whether you've signed a CLA?