Opened 12 years ago

Closed 12 years ago

#5842 closed defect (fixed)

Grid shifts when editors close, causing clicks to be interpreted on the wrong cell

Reported by: benschell Owned by: benschell
Priority: high Milestone: 1.1
Component: DojoX Grid Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Consider the test_edit_dijit.html test page under the Grid page, available here

Double-click a cell in the message column. An Editor widget will show up to allow editing of this field. Next, double-click on some row that is below the row that is currently be editing, first noting the index of the row you're double-clicking. When the double-click event is finished, an editor will be opened on the wrong row, generally several rows down from the originally selected row.

Upon the first click event, the original editor is closed and all rows beneath shift up to make up the space that the Editor widget originally took up. Next, the double-click event is processed to open the editor on the row that the mouse is currently hovering over. However, because the rows were shifted between the first click and the double-click event, the mouse is now over a different row than the user originally intended.

Attachments (1)

5842.patch (1.7 KB) - added by benschell 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by benschell

Status: newassigned

comment:2 Changed 12 years ago by Jared Jurkiewicz

Tested on Firefox 2.0.0.12: Works Okay.

Tested on IE6: Fails with several errors.

First click on grid: Clear Close 'this._click.0.rowIndex' is null or not an objectC:devajaxdojo-1.1dojoxgrid ests est_edit_dijit.html (line 1)

Double-clicks seem to open random rows.

Editor doesn't display right in IE 6 in Grid. Toolbar is missing (probably another bg, just noting here).

comment:3 Changed 12 years ago by dylan

Milestone: 1.1

comment:4 Changed 12 years ago by benschell

I'll check out the IE Editor stuff. New patch uploaded to fix IE behavior (sorry for not testing!)

Changed 12 years ago by benschell

Attachment: 5842.patch added

comment:5 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [12742]) Update to fix double-click cell editor close and open problem. Fix provided by Ben Shell. fixes #5842 !strict

Note: See TracTickets for help on using tickets.