Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#5832 closed enhancement (fixed)

provide native branch for dojo.query() for latest WebKit and/or Safari 3.1

Reported by: alex Owned by: alex
Priority: high Milestone: 1.1
Component: Query Version: 1.0
Keywords: Cc: nathan
Blocked By: Blocking:

Description

as we've always planned for, browsers are starting to implement the native CSS selector APIs. Dojo 1.1's dojo.query() should be updated to deferr to these APIs when available.

Change History (12)

comment:2 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [12371]) update dojo.query to defer to [node].querySelectorAll() if it's available. Fixes #5832. !strict

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: closedreopened

comment:4 Changed 12 years ago by alex

Apple's on it:

http://bugs.webkit.org/show_bug.cgi?id=17313

I'm not keen to roll it back...it's their bug to fix.

comment:5 Changed 11 years ago by alex

(In [13066]) update query() to move combinator-rooted queries off to a non-querySelectorAll branch until the webapis WG decides that they're the right thing to do (which they clearly are). Refs #5832. !strict

comment:6 Changed 11 years ago by nathan

I'm think that this is related to bug #6252...maybe their fix didn't get in before safari 3.1 was released? I have verified this by rolling back these two changes and it fixes the crash in Safari 3.1

Would you potentially be a bit more keen on rolling it back, since it's now affecting the released version of Safari?

comment:7 Changed 11 years ago by alex

lets not roll back. Other browsers are sporting QSA, and the right thing to do is to work around Webkit. A check like:

if((dojo.isSafari && dojo.isSafari > 3.1)&&(...)){
}

comment:8 Changed 11 years ago by nathan

Cc: nathan added

I agree. I think that would be an appropriate solution.

comment:9 Changed 11 years ago by alex

verified w/ the webkit team that this bug:

http://bugs.webkit.org/show_bug.cgi?id=17313

didn't land in time for Safari 3.1. WIll apply a patch to our side.

comment:10 Changed 11 years ago by alex

Resolution: fixed
Status: reopenedclosed

(In [13142]) ensure that we don't blow up on Safari 3.1. Fixes #5832. !strict

comment:11 Changed 10 years ago by bill

Component: GeneralQuery

comment:12 Changed 8 years ago by bill

In [27941]:

Remove codepath for desupported safari 3.1. Refs #5832, #9045, #11844 !strict. Presumably doesn't fix #9045, which is awaiting a test case.

Note: See TracTickets for help on using tickets.