#5832 closed enhancement (fixed)
provide native branch for dojo.query() for latest WebKit and/or Safari 3.1
Reported by: | alex | Owned by: | alex |
---|---|---|---|
Priority: | high | Milestone: | 1.1 |
Component: | Query | Version: | 1.0 |
Keywords: | Cc: | nathan | |
Blocked By: | Blocking: |
Description
as we've always planned for, browsers are starting to implement the native CSS selector APIs. Dojo 1.1's dojo.query() should be updated to deferr to these APIs when available.
Change History (12)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Looks like this breaks webkit, see http://www.dojotoolkit.org/forum/dijit-dijit-0-9/dijit-development-discussion/bordercontainer-webkit-webkit-dojo-nightly#comment-12190. Please fix or rollback.
comment:4 Changed 13 years ago by
Apple's on it:
http://bugs.webkit.org/show_bug.cgi?id=17313
I'm not keen to roll it back...it's their bug to fix.
comment:5 Changed 13 years ago by
comment:6 Changed 13 years ago by
I'm think that this is related to bug #6252...maybe their fix didn't get in before safari 3.1 was released? I have verified this by rolling back these two changes and it fixes the crash in Safari 3.1
Would you potentially be a bit more keen on rolling it back, since it's now affecting the released version of Safari?
comment:7 Changed 13 years ago by
lets not roll back. Other browsers are sporting QSA, and the right thing to do is to work around Webkit. A check like:
if((dojo.isSafari && dojo.isSafari > 3.1)&&(...)){ }
comment:8 Changed 13 years ago by
Cc: | nathan added |
---|
I agree. I think that would be an appropriate solution.
comment:9 Changed 13 years ago by
verified w/ the webkit team that this bug:
http://bugs.webkit.org/show_bug.cgi?id=17313
didn't land in time for Safari 3.1. WIll apply a patch to our side.
comment:10 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:11 Changed 11 years ago by
Component: | General → Query |
---|
see http://webkit.org/blog/156/queryselector-and-queryselectorall/