Opened 12 years ago

Closed 12 years ago

#5824 closed defect (fixed)

BorderContainer center is blank on Safari

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

see test_BorderContainer.html. Center is blank until you touch a splitter, then it redraws correctly.

Change History (8)

comment:1 Changed 12 years ago by bill

This is a race condition loading dijit.css and getting the width: 7px setting for the splitter. BorderContainer? calls dojo.marginBox() on the splitter dom node before the CSS is loaded (or applied?), thus it thinks the splitter's width == the viewport's width.

It's not surprising since the <link rel="stylesheet" type="text/css" media="screen" href="../../../dijit/themes/tundra/tundra.css"> tag (which is dynamically generated) loads asynchronously, and then it in turn does an asynchronous load of dijit.css via an @import statement.

Problem seems to go away if CSS rule is in tundra.css rather than dijit.css.

Should probably add a setTimeout()?

This won't be an issue in a build since builds can inline CSS.

comment:2 Changed 12 years ago by bill

Owner: changed from Adam Peller to bill
Status: newassigned

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [12430]) Fixes #5824: center pane on safari shows up blank sometimes. !strict Actually, doesn't happen on my local machine but it does happen when pulling from dtk.org. It's a race condition.

comment:4 Changed 12 years ago by Adam Peller

(In [12480]) we don't set splitter thickness in layoutChildren anymore. Comment out safari race condition workaround, for now, to avoid infinite loop. haven't seen it happen since the rewrite, but it's probably still there somewhere. Refs #5824 !strict

comment:5 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

comment:6 Changed 12 years ago by Adam Peller

Owner: changed from bill to Adam Peller
Status: reopenednew

comment:7 Changed 12 years ago by Adam Peller

Priority: normalhigh

comment:8 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [12608]) put back code to recompute splitter thickness in layout for Safari CSS race condition. Fixes #5824 !strict

Note: See TracTickets for help on using tickets.