Opened 12 years ago

Closed 12 years ago

#5816 closed defect (fixed)

Editor link dialog complains about errors before user has a chance to input

Reported by: Adam Peller Owned by: Douglas Hays
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

I don't know if this is generally the case with ValidationTextBox, but if you bring up dijit/tests/test_Editor.html and go to the test case for "Optional" toolbar buttons, try the link or image dropdown. You'll be asked for a url in a ValidationTextBox? inside a TooltipDialog?, which has a regexp to do the validation work. Don't type anything yet.

  1. Although the warning icon does not appear, the tooltip complains right away, so the error representation is out of synch.
  2. Type 'h'. Now you get a warning icon and the tooltip remains, so it's in synch, but it's yelling at you before you had a chance to give input and tab out.
  3. Escape out of the dialog. Go back in, and all the error UI is there. How do we reset the state so the user gets a fresh try?

Ditto for the description textbox, which simply does a require=true. These violate some of the rules alex wanted us to fix... can't find the bug reference, but I thought we fixed them?

see also #5815

Change History (3)

comment:1 Changed 12 years ago by Douglas Hays

(In [12346]) References #5816. The invalid message was being shown even when message suppression was active. The part of the defect dealing with resetting message suppression will have to wait for the form reset function since the widget doesn't know that it's been hidden and then make visible.

comment:2 Changed 12 years ago by Douglas Hays

Prerequisite on #2666.

comment:3 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [12483]) Fixes #5816. Added reset() call to popup dialog to blank previous input and errors.

Note: See TracTickets for help on using tickets.