Opened 14 years ago
Closed 7 years ago
#5795 closed defect (patchwelcome)
[Patch] [CLA] Prevent Moveable widgets from moving out of reach
Reported by: | guest | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | blocker | Milestone: | 1.13 |
Component: | DnD | Version: | 1.0 |
Keywords: | DnD Moveable Mover | Cc: | |
Blocked By: | Blocking: |
Description (last modified by )
1)The current implementation of Mover in FF and Safari, allows to drag a a Moveable DOM out of reach (for example you can drag drag a Floating pane far in e.pageX or e.pageY negatives and once you drop it you can't get it back). This patch makes the behavior consistent with IE behavior: once the mouse is north or west of the page, the moving stops.
2)Also, the current default behavior of Mover is to autoScroll. In this patch I change the constructor to take an optional third param (boolean: autoScroll?, defaults to true for backward compatibility). If autoScroll is set to false, when your mouse reaches the end of the viewport it stops moving the Moveable DOM. This is a nice option for apps that simulate a desktop (with html, body {width: 100%; height: 100%;}). I also change Moveable to check for an optional autoScroll entry in the params object.
The first change seems to me like an obvious bug fix. The second seems very useful. If this doesn't seem acceptable, I can submit another solution like to implement a NonScrollableMover? or something like that.
Finally, I changed test_params.html to provide a test of the functionality.
My email for any questions issues: angel dot municio at nexaweb dot com
Attachments (1)
Change History (10)
Changed 14 years ago by
Attachment: | Mover_Moveable.patch added |
---|
comment:1 Changed 14 years ago by
Milestone: | → 1.1 |
---|---|
Status: | new → assigned |
comment:2 Changed 14 years ago by
Milestone: | 1.1 → 1.2 |
---|
Move all milestone 1.1 tickets to 1.2, except for reopened tickets and tickets opened after 1.1RC1 was released.
comment:4 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Priority: | normal → high |
comment:6 Changed 10 years ago by
I actually addressed the Dialog issue in #12238 but I suppose the problem still exists for other draggable objects.
comment:8 Changed 7 years ago by
Summary: | [Patch] [CLA] Prevent Moveable widgets from moving out of reach and make autoScroll behavior configurable. → [Patch] [CLA] Prevent Moveable widgets from moving out of reach |
---|
Update ticket description to reflect that only half of the issue remains.
comment:9 Changed 7 years ago by
Milestone: | future → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | assigned → closed |
This would need an updated patch against master in order to land this. Closing as patchwelcome. I will review immediately if someone wants to create an updated fix for this.
Fix for the ticket