Opened 11 years ago

Closed 11 years ago

#5785 closed defect (fixed)

dojox.gfx, ie6 and setFill

Reported by: guest Owned by: Eugene Lazutkin
Priority: high Milestone: 1.1
Component: DojoX GFX Version: 1.0
Keywords: setfill Cc: tobias@…
Blocked By: Blocking:

Description

There is a problem with the actual setFill-method of the vml.js in the package dojox.gfx. First it cannot fill linear because of a little assign-bug and second the setFill method has a problem, when an element was filled with a gradient (linear, radial, ...) and afterwards filled with just a color. Attached you'll find a patch, that solves these two issues.

Here is a testcase, that is showing both problems:

dojo.require("dojox.gfx");
var surface = dojox.gfx.createSurface("myBox", 100, 100);
var myRect = surface.createRect();
myRect.setFill("red");
dojo.connect(myRect.rawNode, "onmouseover", function() {
    myRect.setFill({type: "linear", x1: 0, y1: 0, x2: 100, y2: 100, 
                    colors: [{offset: 0, color: "black"}, {offset: 1, color: "white"}]});
});
dojo.connect(myRect.rawNode, "onmouseout", function() {
    myRect.setFill("blue");
});

Attachments (1)

vml_js.patch (980 bytes) - added by guest 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by guest

Attachment: vml_js.patch added

comment:1 Changed 11 years ago by Eugene Lazutkin

Milestone: 1.1
Status: newassigned

Thank you for finding a bug, and the constructive approach to it. While patch is rather trivial, please file a CLA (http://dojotoolkit.org/cla), and mark this ticket with [patch] and [cla].

comment:2 Changed 11 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [12663]) gfx: two cleanup statements added. The fix is based on the patch submitted without CLA --- but used nevertheless due to triviality of changes. Thx, Tobias and Alex Russell for fixing my mistakes. Fixes #5785 !strict

Note: See TracTickets for help on using tickets.