dijit.form._ComboBoxDataStore not complete

[nathan]

The dijit.form._ComboBoxDataStore doesn't fully implement the data api - it needs to implement a getFeatures() function:

getFeatures: function(){ return {"dojo.data.api.Read": true, "dojo.data.api.Identity": true};}

should be sufficient for it.

Also - the fetch() function isn't happy if query or queryOptions is missing. It might be nice to do something like:

if (!args.query){ args.query = {}; } if (!args.query.name){ args.query.name = "*";} if (!args.queryOptions){ args.queryOptions = {};}

at the beginning of the fetch() function

[guest]

Sorry - forgot to mention - this is from an svn snapshot from this morning.

[guest]

Scope is also not honored - nor is onBegin or onItem...it might be easiest to mixin dojo.data.util.simpleFetch and implement _fetchItems instead.

[guest]

Patch to add getFeatures to combobox and leverage simpleFetch for better fetching compatibility

[bill]

That's correct, by design dijit.form._ComboBoxDataStore doesn't implement the full dojo.data.store API. Is there an actual problem with ComboBox? that you are seeing?

[guest]

The issue I'm seeing isn't with ComboBox? itself...it's with a subclass of it that I've created. In 1.0, the ComboBox? mixin used an ItemFileReadStore? to represent its data - so my subclass of it keys off of the fact that it's a "real" datastore (passing in scope for fetch, and using getFeatures to determine if it's a read-only store or if it supports writing.)

I can change my subclass - it's not a huge deal - but I would suggest that fully implementing the dojo.data.api.Read api should be done if it's really "using" a datastore. If, for performance reasons, it is better not to implement the full API, then I would suggest not calling it a "store" - to avoid confusion when subclassing.

[bill]

Hi Nathan,

OK, that makes sense. The reason I didn't implement the full store API was to reduce the code size, but it looks like your patch is pretty small so I guess we can integrate it.

Have you signed the CLA?

[guest]

No - I haven't...I need to though. :)

[guest]

I faxed in a CLA earlier today - I didn't get any sort of receipt confirmation back or anything, if that's needed.

[bill]

OK, Nathan's a committer now so I will let him check in the patch.

[nathan]

Updated patch.

[nathan]

Fixed in [13300]