Opened 11 years ago

Closed 11 years ago

#5761 closed defect (fixed)

Height-less Grid still displays header nodes

Reported by: benschell Owned by: benschell
Priority: high Milestone:
Component: DojoX Grid Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

After some testing related to #5343, I've found that, even when the Grid sizes itself to 0px tall (due to it's parent not having an appropriate height set), the column headers still appear. If the Grid is sizing itself to a zero height, the column headers should be hidden as well, otherwise the Grid appears broken (when in fact it's just not displayed).

Attachments (2)

5761.patch (1.7 KB) - added by benschell 11 years ago.
Fixed absolute paths in previous patch
dojox.grid.VirtualGrid_20080212.patch (1.6 KB) - added by Jared Jurkiewicz 11 years ago.
Minor cleanup of Ben's patch.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by benschell

Status: newassigned

I've included a modification to the test_sizing.html test file which includes a Grid instance in an unsized container. The behavior can be seen with the given fix not included. The rest of the patch corrects the behavior.

Changed 11 years ago by benschell

Attachment: 5761.patch added

Fixed absolute paths in previous patch

comment:2 Changed 11 years ago by Jared Jurkiewicz

Talked with Ben on this and I agree with his fix. If the parent container has 0 size, then nothing of the grid should display. Otherwise, it does appear broken that the header displays, but no data. It tends to suggest that the data model is wrong somehow when it actually wasn't.

Changed 11 years ago by Jared Jurkiewicz

Minor cleanup of Ben's patch.

comment:3 Changed 11 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [12420]) Applying patch from Ben Shell. Minor fix. Fixes #5761 !strict

Note: See TracTickets for help on using tickets.