dojo.io.checkChildrenForFile evaluates length.getAttribute - is not a function

[s.milek@…]

Using dojo.io.bind with a formNode, I get an exception in dojo.io.checkChildrenForFile (BrowserIO.js line 15 / trunk HEAD) :

"input.getAttribute is not a function"

this is because the result of the call on line 12 of BrowserIO.js:

var inputs = node.getElementsByTagName("input");

'inputs' does not evaluate to an Array according the dojo.lang.isArray, which is called in dojo.lang.forEach

this eventually causes inputs.length.getAttribute() to be attempted

in Venkman, 'inputs' is an HTMLCollection object (FF1.5 WinXP)

based on the svn log for lang/common.js, dojo.lang.forEach was modified a couple of times each by 2 different developers on 03-24. This may be part of it. I do not know if this was a problem prior to now, because I just created this case.

Also, the form is created via ContentPane?.setContent, which uses innerHTML. I'm mentioning this because I'm imagining that the node-tree created via setting innerHTML may have peculiarities about it that cause the error in my case but not in the normal case (where the content is not set with innerHTML).

Thanks.

[anonymous]

should dojo.lang.forEach be calling dojo.lang.isArrayLike instead of isArray?

[jeoffwilks@…]

I hit this same bug when trying to migrate from 0.2.2 to trunk in order to gain other features.

Blocks use of "formNode" in dojo.io.bind().

It seems to work for me when I change dojo.lang.forEach to test for isArrayLike in place of isArray, as suggested above.

[jeoffwilks@…]

as suggested in first comment

[James Burke]

This appears to be fixed after the latest changes to dojo.lang.forEach (just checked in later today). I just tried with test_IframeIO.html with the latest from SVN, and I did not get any errors.

[alex]

does this still work? It looks like sjmiles rolled back his patch to forEach. We should retest.

[anonymous]

It was fixed by [3398]. It looks like some tests were added in [3399].

FYI: tying tickets to changesets is a lot easier if you use Trac's post-commit hook script with Subversion:

• ​http://projects.edgewall.com/trac/browser/trunk/contrib/trac-post-commit-hook

[(none)]

Milestone 0.3release deleted