Parsing bad JSON text should throw an error

[kriszyp]

When Dojo.fromJson is called with an invalid Json string, it returns the provided string when it should fail (throw an exception). It is irrational to return a wrong result rather than failing.

[kriszyp]

patched json.js

[kriszyp]

patched unit test for json.js

[Adam Peller]

we agree. technically, this would violate compatibility, but it's the right thing to do. thoughts?

[Frank Fortson]

Sounds reasonable. I plan to post a patch to support complex queries in ItemFile?Store. It uses a string argument to "query", which works fine...except when dojo parses markup, it (I assume it is the parser) assumes the value of "query=" should be a json object and at some point dojo.fromJson is called. It now just prints a syntax error to console. Making the above change prior to finding where and possibly correcting the markup parsing will break the complex query patch. Guidance?

[bill]

You could change ItemFileReadStore? to make query a string parameter, and then in the constructor manually convert it to a JS object. Take the parser out of the equation. For programmatic creation, still allow query to be specified as a string or an object and then in the constructor do { if ( typeof this.query == "String" )

[bill]

PS: above comment by frankf is about #5735. Looking more closely at that bug, it's unclear that complex query support should use the query parameter or even be part of ItemFileReadStore. See #5735 for details.

[Adam Peller]

(In [12247]) throw for bad json. Refs #5725