Opened 13 years ago
Closed 13 years ago
#5723 closed enhancement (fixed)
Make Dojo work with Adobe AIR
Reported by: | dylan | Owned by: | alex |
---|---|---|---|
Priority: | high | Milestone: | 1.1 |
Component: | Core | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Attachments (8)
Change History (15)
comment:1 Changed 13 years ago by
Status: | new → assigned |
---|
Changed 13 years ago by
Attachment: | DojoAIRProject.pdf added |
---|
Changed 13 years ago by
Attachment: | index.html added |
---|
patch listing tests and features for Adobe AIR
Changed 13 years ago by
Attachment: | dojo-build-profile.js added |
---|
patch of build profile for Adobe AIR
comment:2 Changed 13 years ago by
Somewhere in the source or documentation, we should add "Adobe and SitePen? collaborated on these modifications."
Changed 13 years ago by
Attachment: | application.xml added |
---|
patch for Adobe AIR's application.xml config file
comment:3 Changed 13 years ago by
For dojo.patch, it has a branch point on dojo.isAIR (should that be dojo.isAir?) for things that call setTimeout. I would prefer not to have a branch and to preserve the use of dojo._scopeName within AIR. Instead of having the branch points can we do something like (for example):
setTimeout(function(){window[dojo._scopeName].loaded();}, 0);
This assumes:
- "window" exists in AIR
- We don't leak in browsers like IE with those closures.
I think we are OK with the closures, not sure about "window" support in AIR.
comment:4 Changed 13 years ago by
Ugh, forgot to scrub that window may not be in all our hostenvs. So window might not be so good. "this" instead?
comment:5 Changed 13 years ago by
On further reflection, the closure path used in the patch should be sufficient for all hostenvs, and it will preserve the scope functionality. That was the whole point of the scope changes: so that you do not need to modify the library code to know about it unless you are making string IDs or string callbacks. So this should be sufficient, no need for a dojo.isAIR (or dojo.isAir) check:
setTimeout(function(){dojo.loaded();}, 0);
comment:7 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Moving documentation issue to #5883
Documentation/known issues