Changes between Version 9 and Version 13 of Ticket #5707


Ignore:
Timestamp:
Aug 28, 2010, 11:57:53 AM (11 years ago)
Author:
bill
Comment:

You certainly don't need to modify Editor.js to register a plugin, but I agree that using dojo.subscribe() is strange. I thought Cougar said there was some reason, like that Editor wasn't loaded yet when the plugins were loaded, so they couldn't just register themselves? I don't see why that would happen though.

AdapterRegistry doesn't seem right either since all we really need is a dictionary mapping plugin name (short name like "createLink") to plugin. Actually, I'm not sure why plugins need to be registered at all (except to support that short name --> proper name mapping).

In any case, marking this for 2.0 to decide then.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5707

    • Property Priority changed from high to normal
    • Property Keywords refactor added
    • Property Milestone changed from 1.3 to 2.0
  • Ticket #5707 – Description

    v9 v13  
    33While trying to write about plugins, I quickly ran out of creative ideas for how to tell someone to write their own custom plugin without suggesting that they hack on Editor.js (which currently has a bunch of case statements that handle some of this stuff.) Am I wrong, and there is there is a fairly simple and elegant way to create custom plugins w/o doing that?
    44
    5 Also, it might be worth talking about how you should and shouldn't pass in values to plugins. For example, on the EnterKeyHandlingPlugin, I don't see a better way of specifying blockNodeForEnter than adding a call to
     5Also, it might be worth talking about how you should and shouldn't pass in values to plugins. For example, on the !EnterKeyHandlingPlugin, I don't see a better way of specifying blockNodeForEnter than adding a call to
    66{{{
    77dojo.extend(dijit._editor.plugins.EnterKeyHandling, {