Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#5689 closed enhancement (fixed)

[patch][cla] BorderContainer collapsible feature

Reported by: Adam Peller Owned by: dante
Priority: high Milestone: 1.3
Component: Dojox Version: 1.0
Keywords: BorderContainer Cc:
Blocked By: Blocking:

Description

Not sure what to call this exactly -- please make suggestions here -- but I think we need an option on the edge panes to have a little icon, sort of like an AccordionPane?, to collapse/expand the pane in the layout. Shouldn't be too hard to do.

Attachments (1)

expandoPane_20080219.patch (1.5 KB) - added by Sam Foster 12 years ago.
[CLA] [PATCH] Adds (partial) support for vertical orientation expand/collapse.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by Adam Peller

Summary: BorderContainer expando featureBorderContainer collapsible feature

comment:2 Changed 12 years ago by dante

(In [12404]) experimental expandopane in dojox - refs #5689 test has working bordercontainer with three children (two expando's and a tab in the center). left expando has three tabs (bottom aligned) and center tab has accordionContainer. right expando has AccordionContainer? as child.

Changed 12 years ago by Sam Foster

Attachment: expandoPane_20080219.patch added

[CLA] [PATCH] Adds (partial) support for vertical orientation expand/collapse.

comment:3 Changed 12 years ago by Sam Foster

Cc: dante added

expandoPane_20080219.patch goes some way towards supporting expand/collapse in vertical as well as horizontal orientation for the dojox.layout.ExpandoPane?. Sorry, didnt get to tests and css but I wanted to put this back on the stack for the next person.

comment:4 Changed 12 years ago by dante

(In [12518]) refs #5689 - add top/bottom expando option based on sfoster's patch. adds new test, and other cleanups.

comment:5 Changed 12 years ago by Adam Peller

Cc: bill dante removed
Component: DijitDojoX Widgets
Owner: changed from Adam Peller to dante

comment:6 Changed 12 years ago by bill

Component: DojoX WidgetsDijit
Owner: dante deleted

I'd like for this to be in dijit eventually, possibly a different architecture where the code is in BorderContainer? itself not in a separate widget.

comment:7 Changed 11 years ago by dylan

Owner: set to dante
Summary: BorderContainer collapsible feature[patch][cla] BorderContainer collapsible feature

What's the plan on this?

comment:8 Changed 11 years ago by dante

to be merged w/ genro's patch pending CLA reception. sent friday, allegedy. refs #6781

comment:9 Changed 11 years ago by bill

Milestone: 1.21.3

Let's do the integration of collapsability into dijit for 1.3; 1.2 is focusing on purely visual issues.

As I said above, I hadn't envisioned doing this as a separate widget (ie, requiring the user to use an ExpandoPane to wrap their "real" widget), but rather to have it built in to BorderContainer, although it's up for discussion.

In any case, need to make sure the borders show up correctly so should wait for Nikolai to finish the refactoring (#6437, #6438, #6768). (Note that nesting a TabContainer inside an ExpandoPane could exacerbate the border problem.)

comment:10 Changed 11 years ago by dante

I want to say this is fixed. There is a ToggleSplitter in DojoX, though iirc requires you to subclass BorderContainer and overwrite the private _splitterClass variable?

ExpandoPane provides any leftover use case functionality. Thinking about it, it may be possible for ExpandoPane to be title-less, but that just makes it a ContentPane with a ToggleSplitter setup, huh?

comment:11 Changed 11 years ago by bill

Milestone: 1.31.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:12 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

The goal is to make ExpandoPane? work and merge into Dijit (afaik). Marking this as fixed because this was part of the motiviation. Obviously there are other UI nits that could come of this, but the basic premise is some sort of toggle-able pane needs to exist in BC. Expando has the most momentum.

comment:13 Changed 10 years ago by bill

Component: DijitDojox
Milestone: 1.41.3

OK, marking this as dojox since that's where ExpandoPane is; we can have another ticket for merging the functionality into dijit.

Note: See TracTickets for help on using tickets.