Opened 14 years ago

Closed 14 years ago

#5681 closed defect (fixed)

dialog: incorrect title text on close icon

Reported by: Becky Gibson Owned by: Becky Gibson
Priority: high Milestone: 1.1
Component: Accessibility Version: 1.0
Keywords: Cc:
Blocked By: Blocking:


The close icon is inheriting the title text from the dialog title div. Thus, when I user hovers over the close icon they see the title of the dialog displayed in the browser provided tooltip. This is easily fixed by adding a title attribute to the close icon. The biggest issue is that the title text will need to be translated. There is currently a buttonCancel string of "cancel" defined in dijit/nls/common.js which has already been translated. Should we just use "cancel" for the title of the icon or should the text be "close"?

This would be worth adding to a 1.0.3 build if there is one.

Change History (2)

comment:1 Changed 14 years ago by Adam Peller

My suggestion: since there's nothing else pending to be translated for 1.0.3, and maybe not even for 1.1, stick with 'cancel' if you think it's at all appropriate, and file another ticket for 2.0 to make a new string for 'close'.

comment:2 Changed 14 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [12197]) fixes #5681 Add localized "cancel" text to the icon and the a11y text equivalent span (need both for IE to work).

Note: See TracTickets for help on using tickets.