Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#5669 closed defect (fixed)

Dialog: can't contain layout widgets

Reported by: bill Owned by: bill
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Split off from #4169:

Since layout widgets can't render inside a hidden div (at least on some browsers), tabs etc. don't work correctly inside of a Dialog.

Change History (6)

comment:1 Changed 11 years ago by bill

Owner: set to bill
Status: newassigned

comment:2 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [12161]) Fixes #5669: Dialog can't contain layout widgets. Modifies Dialog to initialize in a visibility:hidden state rather than display:none, in order for possible child layout widgets to initialize correctly. As Dialog is not a layout widget itself, note that this means that the child layout widgets must have a size specified (rather than specifying a size on the Dialog itself)

comment:3 Changed 11 years ago by bill

(In [12163]) Put width on the dialog loaded from an href containing a <p>, so it doesn't become too wide and hit the edge of the viewport. All dialogs should have a specified width unless they are naturally narrow (because they contain a form or something like that).

Refs #5669.

comment:4 Changed 11 years ago by bill

(In [12179]) If dialog is marked as display:none in markup, override it since we are making it visibility:hidden instead. Fixes dialog display in themeTester. Refs #5669.

comment:5 Changed 10 years ago by bill

(In [15986]) Fix for ContentPane?-based templated widgets that contain nested layout widgets, and add test case.

For templated widgets, in order to check if there was original content, we need to check the contents of srcNodeRef before they are copied to containerNode. (Alternately could just check if anything is in containerNode.)

Fixes #5669, #5670, #5671. !strict

comment:6 Changed 10 years ago by bill

Description: modified (diff)

Note that as of [15986], [12161] is no longer necessary. OTOH I guess it isn't hurting anything.

Will probably roll it back when #2056 is changed, i.e. when we don't move the Dialog etc. except for the duration that it's actually being shown.

Note: See TracTickets for help on using tickets.