Opened 12 years ago

Closed 12 years ago

#5662 closed defect (fixed)

Animation _cycle keeps fires indefinately

Reported by: guest Owned by: alex
Priority: high Milestone: 1.1
Component: Core Version: 1.0
Keywords: Cc: dante
Blocked By: Blocking:

Description

I'm having an issue with animations that keep firing code even when they are not in use. Makes debugging difficult. Steps to reproduce...

1) Open http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Dialog.html in IE7. (It may happen on other browsers...)

2) Click the "Show Dialog" button

3) Click "OK"

4) Click "OK"

You should know be back at the initial screen with no dialogs open.

5) Attach a debugger (I'm using VS2008, but any debugger should work.)

6) Pause the process and you will be probably be stopped at a "line" of code in dojo.hitch depending how "lucky" you are. If you follow the code in for awhile it is actually a loop calling dojo._Animation._cycle.

The Dialog uses fade in/out while showing/hiding. Why is this code continuing to be fired even after the animation is done?

Thanks schallm

Change History (4)

comment:1 Changed 12 years ago by Adam Peller

Cc: dante added
Milestone: 1.1

comment:2 Changed 12 years ago by alex

Owner: changed from anonymous to alex
Status: newassigned

comment:3 Changed 12 years ago by alex

verified. This is really bad. Thanks for finding it.

comment:4 Changed 12 years ago by alex

Resolution: fixed
Status: assignedclosed

(In [12493]) ensure that animations which end "naturally" decrement the timer and attempt to cancel the global interval if apropos. Fixes #5662. !strict

Note: See TracTickets for help on using tickets.