Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#5635 closed defect (fixed)

TabContainer: nested tabs broken (programmatic creation)

Reported by: guest Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: BorderContainer Cc:
Blocked By: Blocking:

Description (last modified by bill)

The test_LayoutCode.html in dijit/tests/layout shows the problem:

Firefox (2.0.0.11) Click the 'Tab Layout' button. Then click the 'Nested tabs' button - the tabs are displayed as expected. Now click on the Content tab (this displays correctly), then click back on the Nested tabs - nothing is displayed. (There is a similar problem with the 'split pane' tab.)

IE7 Click on the Tab Layout button. Nothing happens.

The test_tabContainer works fine (in both Firefox and IE7), but there is no example of the sub-tabs being in-line text (all sub-tabs are Link Panes with an href)

Sadly, this is stopping us from moving from 0.4

Attachments (1)

test_TabContainer.html (6.7 KB) - added by bill 12 years ago.
declarative test case for nested tabs (working correctly on FF2 and IE6)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by Adam Peller

Keywords: BorderContainer added
Milestone: 1.1

comment:2 Changed 12 years ago by bill

Description: modified (diff)
Owner: set to bill
Summary: Nested tabs broken under 1.02Nested tabs broken

I assume you mean test_LayoutCode.html not test_LayoutContainer.html, so updating the description as such. I did reproduce the problem in trunk. Will investigate.

comment:3 Changed 12 years ago by bill

Milestone: 1.11.2
Summary: Nested tabs brokenNested tabs broken (programmatic creation)

I tried changing test_TabContainer.html to have nested tabs without hrefs, and they work fine. It's just a problem with programmatic creation (or with the test_LayoutCode.html testcase itself). Will attach testcase.

Changed 12 years ago by bill

Attachment: test_TabContainer.html added

declarative test case for nested tabs (working correctly on FF2 and IE6)

comment:4 Changed 12 years ago by bill

Summary: Nested tabs broken (programmatic creation)TabContainer: nested tabs broken (programmatic creation)

comment:5 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [14610]) Clean up/expand programmatic tests for layout widgets. Fixes #5635.

comment:6 Changed 8 years ago by bill

(In [24033]) Fix failure on IE9 when run through runTests.html. Seems like the problem line was always missing parentheses, it should have always been (new ContentPane?()).placeAt(...) not new ContentPane?().placeAt(), not sure why it worked without parentheses on other browsers or on IE9 when run individually. Refs #5635.

comment:7 Changed 8 years ago by bill

(In [24099]) Merge [24033] test fix to 1.6/ branch, refs #5635.

Note: See TracTickets for help on using tickets.