Opened 12 years ago

Closed 11 years ago

#5634 closed defect (fixed)

[patch][cla] dojo.animateProperty does not use current style for colors if start or end missing

Reported by: Rawld Gill Owned by: Bryan Forbes
Priority: high Milestone: 1.1
Component: Core Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Rawld Gill)

If a color (e.g. "backgroundColor") is specified with only a start or end value, then revision 12117 attempts to use the current value of that property for the missing end point.

However, the closed getStyle function (line 426 of fx.js) calls parseFloat (line 431) on a "rgb(x, y, z)" value. This returns NaN and the end point ends up being white.

Example of problem and proposed repair attached. Repair tested in FF and IE.

Attachments (2)

dojo.fx.error.htm​ (514 bytes) - added by Rawld Gill 12 years ago.
reproducable example
diff​ (516 bytes) - added by Rawld Gill 12 years ago.
diff with correction

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Rawld Gill

Attachment: dojo.fx.error.htm​ added

reproducable example

Changed 12 years ago by Rawld Gill

Attachment: diff​ added

diff with correction

comment:1 Changed 12 years ago by Rawld Gill

Description: modified (diff)

comment:2 Changed 12 years ago by dylan

Milestone: → 1.1
Owner: changed from anonymous to Bryan Forbes
Summary: dojo.animateProperty does not use current style for colors if start or end missing → [patch][cla] dojo.animateProperty does not use current style for colors if start or end missing

comment:3 Changed 11 years ago by Bryan Forbes

Resolution: → fixed
Status: new → closed

(In [13040]) fixes #5634. !strict

  • If the property is a color, just pass its value through to get created into a dojo.Color later on.
Note: See TracTickets for help on using tickets.