Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5625 closed defect (fixed)

Error in doh.registerTestNs logic

Reported by: ptwobrussell Owned by: alex
Priority: high Milestone: 1.1
Component: TestFramework Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

I noticed a comment on http://dojotoolkit.org/book/dojo-book-0-9/part-4-meta-dojo/d-o-h-unit-testing

that appears to be correct. Didn't see a ticket already filed on it, so I wanted to add it in here. The basic issue seems to be that the logic is supposed to ignore functions with a leading _, but the logic in place accepts them exclusively.

From that page:

doh.registerTestNs = function(/*String*/ group, /*Object*/ ns)

line 331:

if( (x.charAt(0) == "_") &&

should be changed to

if( (x.charAt(0) != "_") &&

Change History (2)

comment:1 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [12610]) update doh.registerTestNs logic to correctly filter for privates. Fixes #5625. !strict

comment:2 Changed 12 years ago by alex

Milestone: 1.1
Note: See TracTickets for help on using tickets.