Opened 11 years ago

Closed 11 years ago

#5617 closed defect (fixed)

[patch][ccla]Editor: in mail demo, new message page yields page loading error (IE)

Reported by: Adam Peller Owned by: alex
Priority: high Milestone: 1.1
Component: Dijit Version: 1.1b1
Keywords: Cc: liucougar, bill
Blocked By: Blocking:

Description (last modified by bill)

In mail.html, hit "New Message", then close the tab (click the x), click OK to "are you sure you want to leave your changes?" then hit "New Message" again. 404 error.

Happens on IE6.

Attachments (2)

no_src_IE6.gif (16.3 KB) - added by Douglas Hays 11 years ago.
screen shot of IE6 error
5617.3.patch (1.3 KB) - added by Douglas Hays 11 years ago.
refreshed stale patch to fix merge problems

Download all attachments as: .zip

Change History (17)

comment:1 Changed 11 years ago by bill

Owner: set to Adam Peller

Not happening for me, on IE6 or IE7 or FF. Still happening for you?

comment:2 Changed 11 years ago by Adam Peller

Resolution: worksforme
Status: newclosed

works as of 2008-01-24

comment:3 Changed 11 years ago by bill

Description: modified (diff)
Resolution: worksforme
Status: closedreopened
Version: 1.01.1b1

comment:4 Changed 11 years ago by bill

Priority: normalhigh

comment:5 Changed 11 years ago by bill

Patch fixes problem on mail.html. Concerning the line:

ifr.src = 'javascript:void(0)';

Patch removes that line, but things seems to work even when that line is there. If it's removed then loading test_Editor.html gets warnings about "this page contains both secure and insecure content".

comment:6 Changed 11 years ago by Adam Peller

I see javascript:"" used in popup.js. Is that the same thing?

I don't see the try/catch nor the setTimeout pattern used in popup.js, though. Why is it not an issue there?

also, the 'var e' is unnecessary.

comment:7 Changed 11 years ago by Adam Peller

Cc: liucougar alex added

comment:8 Changed 11 years ago by Douglas Hays

When I leave the ifr.src='javascript:void(0)' statement in, I get an error on IE6:

screen shot of IE6 error

Changed 11 years ago by Douglas Hays

Attachment: no_src_IE6.gif added

screen shot of IE6 error

comment:9 Changed 11 years ago by Douglas Hays

Using ifr.src=; also makes the IE6 error go away for me. I'm not getting the mixed content message with any combination.

comment:11 Changed 11 years ago by bill

Summary: IE: mail demo, new message yields page loading errorEditor: in mail demo, new message page yields page loading error (IE)

comment:12 Changed 11 years ago by bill

Owner: changed from Adam Peller to alex
Status: reopenednew

As per meeting today, Alex want to poke at this and see if he can find a solution w/out a timer, like in http://trac.dojotoolkit.org/browser/dojo/trunk/io/iframe.js#L101 (not sure how that's related but was mentioned in the meeting). Cougar is OK with the third patch above.

Changed 11 years ago by Douglas Hays

Attachment: 5617.3.patch added

refreshed stale patch to fix merge problems

comment:13 Changed 11 years ago by Douglas Hays

Cc: bill added; alex removed

The OK and Cancel buttons are no longer showing on the New Message panel using IE6 with the 5617.3.patch. Pretty sure this used to work a few days ago.

comment:14 Changed 11 years ago by Douglas Hays

The patch is still working. The missing Send/Cancel? buttons are from a separate regression covered by #6208.

comment:15 Changed 11 years ago by Adam Peller

Summary: Editor: in mail demo, new message page yields page loading error (IE)[patch][ccla]Editor: in mail demo, new message page yields page loading error (IE)

comment:16 Changed 11 years ago by alex

Resolution: fixed
Status: newclosed

(In [13138]) clean patch for #5617 that avoids timer for all but IE 6. Fixes #5617. !strict

Note: See TracTickets for help on using tickets.