Opened 11 years ago

Closed 11 years ago

#5611 closed enhancement (fixed)

minor cleanups to _base/fx.js

Reported by: dante Owned by: dante
Priority: high Milestone: 1.1
Component: Core Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

half of fx.js is in a closure. small cleanups can be made by wrapping the remainder in a closure and using the var d = dojo; more.

Attachments (1)

fx.patch (4.3 KB) - added by dante 11 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 11 years ago by dante

(In [12074]) refs #5611 - ugly (safe) patch moves closure up to top. precedes coming patch to do other cleanups, that otherwise would be unreadable with this patch included. !strict

Changed 11 years ago by dante

Attachment: fx.patch added

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

(In [12110]) fixes #5460 - makes public method fire() private (_fire) because you should never ever call it. also changes the return value of stop() if called on a non-running animation, so if you were relying on undefined coming back, you can now reliablly chain .status() on .stop() instead ... fixes #5611 - some d = dojo love cleanups included !strict

Note: See TracTickets for help on using tickets.