Opened 11 years ago

Closed 11 years ago

#5608 closed defect (fixed)

1.0.2 build.bat/sh broken

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.0.2
Component: BuildTools Version: 1.0
Keywords: build tools shrinksafe rhino Cc:
Blocked By: Blocking:

Description

The 1.0.2 build tools tarballs don't have the shrinksafe/ folder rolled into them. So the build packages here: http://download.dojotoolkit.org/release-1.0.2/dojo-release-1.0.2-buildscripts.tar.gz http://download.dojotoolkit.org/release-1.0.2/dojo-release-1.0.2-buildscripts.zip

Are not able to build the Dojo source.

Change History (5)

comment:1 Changed 11 years ago by dante

Milestone: 1.0.31.1
Priority: highestnormal
severity: blockerminor

actually, there isn't much use at all for the buildscripts release, because currently you cannot re-build a built dojo (dojo-release-1.0.2.*) you need the -src release, which includes the buildscripts and shrinksafe.

if building from a build release is fixed, this will be an issue, but for now it's just pointing out the redundancy of the buildscripts archive.

leaving for jburke to decide what should be done.

comment:2 Changed 11 years ago by guest

Correct me if I'm wrong, but the 0.9 release's buildscripts package did have ability to build with the src.

I have the Dojo source-only package, but I have no way to get a public package to build it? Is that correct?

My project is such that I cannot simply use the dojo SVN repository to acquire Dojo src and build tools.

comment:3 Changed 11 years ago by dante

there are three files to each release:

http://download.dojotoolkit.org/release-1.0.2/dojo-release-1.0.2.tar.gz ~ 3m - built dojo.js / dijit / dojox

you cannot build dojo from this release. even with the buildscripts.tar.gz (which is the issue of this ticket)

http://download.dojotoolkit.org/release-1.0.2/dojo-release-1.0.2-src.tar.gz ~ 15m - unbuilt dojo.js / dijit / dojox / util + shrinksafe

is the source release. it can be used to build dojo.js and all layers you like. it can safely replace a built dojo and dojo.js, though is considerably slower until you build.

comment:4 Changed 11 years ago by Adam Peller

Milestone: 1.11.0.2
Owner: changed from James Burke to Adam Peller

I've gotta fix this for 1.0.2.

dante, this is here as a convenience for those who don't keep util around.

So I moved rhino out of util/buildscripts to a more common location in util/shrinksafe (see #4720) just to clean things up and make the licensing clearer, but that no longer gets picked up by the buildscripts tarball which is util/buildscripts only, and there's a dependency there.

I could a) add util/shrinksafe to the tarball b) add an additional shrinksafe tarball c) put a copy of custom_rhino back into buildscripts d) just move it back into buildscripts.

Offering shrinksafe as a separate tarball doesn't seem like such a bad idea -- the only form we currently offer is some OSX executable which isn't up to date. Thoughts? Sorry I messed this up.

comment:5 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [12071]) Add util/shrinksafe/ to buildscripts tar. Fixes #5608

Note: See TracTickets for help on using tickets.