Opened 14 years ago

Closed 13 years ago

Last modified 12 years ago

#560 closed enhancement (fixed)

Dojo builds should not re-define the root Dojo object if included twice

Reported by: alex Owned by: James Burke
Priority: high Milestone:
Component: Core Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

When a dojo.js file is included twice, it does not do the "right thing". Both builds and the "source" version of Dojo should include prevention for this.

Change History (5)

comment:1 Changed 14 years ago by alex

Milestone: 0.3release0.3.1
Owner: changed from alex to James Burke

not sure if this should 0.3, 0.3.1, or 0.4. Moving to 0.3.1.

comment:2 Changed 14 years ago by James Burke

Alex, how much should be protected? Just redefining the base dojo object, or the whole dojo.hostenv object? What problem is the bug trying to solve? Maybe just having to re-download packages? If so, then I think just making sure dojo is not reset to an empty object is enough.

comment:3 Changed 14 years ago by alex

I think what we're looking for here is an if(){} statement around everything inside of whatever dojo.js happens to be in play. In essence, we don't want to run *anything* in a re-included dojo.js if the dojo.* namespace is already created.

comment:4 Changed 13 years ago by James Burke

Resolution: fixed
Status: newclosed

Fixed in 4185.

comment:5 Changed 12 years ago by (none)

Milestone: 0.3.1

Milestone 0.3.1 deleted

Note: See TracTickets for help on using tickets.