Opened 11 years ago

Closed 11 years ago

#5578 closed enhancement (fixed)

[dojox] Lightbox - factor out repetitive fade animations

Reported by: dante Owned by: dante
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

some animations in Lightbox (specifically the two being combined in _loadimage) probably only need to be created once, and replayed.

refactor this up to postcreate.

nice to see a 1.2 milestone.

Change History (3)

comment:1 Changed 11 years ago by dante

Status: newassigned

note to self: pay special note to repeating animations with unnecessary internal connections (onEnd:function(){}) for the sake of long lived single-instance pages.

comment:2 Changed 11 years ago by dante

Milestone: 1.21.1

comment:3 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [12168]) fixes #5578 and fixes #5234 - if image larger than viewport, scale down maintaing aspect ratio. also onerror cleanup to remove redundant disconnect() connect() sequence, size optimizations (_t) and finish moving out available animations to semi permenant instance vars.

thanks nikolai for making me finish this old patch I had otherwise abandoned.

Note: See TracTickets for help on using tickets.