Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5571 closed defect (fixed)

Grid -- text box -- single click does not clear selection

Reported by: guest Owned by: benschell
Priority: high Milestone:
Component: General Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Picky, but users who have to use this all day long find this very annoying:

When text in a grid edit box is selected, single clicking in the text does *not* deselect the text and place the cursor.

To reporoduce: go to

dojo/dojox/grid/tests/test_edit.html

in the top row, double click "But are not followed by two hexadecimal" and then single click the "not" as if to deleted it (or change a spelling mistake)

the single click does nothing and the text remains selected. You must use an arrow key to deselect the text.

This is especially annoying since the text automatically selects when double clicking and opening up the grid edit -- removing the "select" below seems appease users, but this still seems like a bug:

dojox.grid.focusSelectNode = function(inNode) {

try{

dojox.grid.fire(inNode, "focus"); dojox.grid.fire(inNode, "select"); -DL Selecting all of the text annoys users

}catch(e){ IE sux bad }

};

Attachments (2)

5571.patch (561 bytes) - added by benschell 12 years ago.
5571.2.patch (562 bytes) - added by Jared Jurkiewicz 12 years ago.
Minor stylistic update.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by Douglas Hays

Owner: changed from anonymous to benschell

comment:2 Changed 12 years ago by benschell

Status: newassigned

The primary issue here is that the click-handling is putting the focus on the cell (rather than let it fall through to the native editor nodes). Patch attached which, if the current event's target is the cell that is currently being edited, doesn't squash the focus.

Changed 12 years ago by benschell

Attachment: 5571.patch added

Changed 12 years ago by Jared Jurkiewicz

Attachment: 5571.2.patch added

Minor stylistic update.

comment:3 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [12516]) Minor patch to grid editing selection events from Ben Schell. fixes #5571

comment:4 Changed 12 years ago by Jared Jurkiewicz

Tested on:

Firefox 2.0.0.12

IE 6

Safari B3

Note: See TracTickets for help on using tickets.