Opened 11 years ago

Closed 11 years ago

#5540 closed defect (fixed)

The bug of the storage provider's function hasKey

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: storage dojox Cc: Tom Trenka, alex
Blocked By: Blocking:

Description

This is such a simple bug.

The original code is hasKey: function(/*string*/ key, /*string?*/ namespace){ /*Boolean*/ summary: Determines whether the storage has the given key.

return (this.get(key) != null);

},

I think is should be like this hasKey: function(/*string*/ key, /*string?*/ namespace){ /*Boolean*/

return (this.get(key, namespace) != null);

},

Thanks.

Attachments (1)

provider.patch​ (1.6 KB) - added by Adam Peller 11 years ago.
general cleanup with proposed change to hasKey. need to build and test this

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by Adam Peller

Cc: Tom Trenka alex added
Milestone: 1.0.3 → 1.1

seems logical to me, but it's code I barely understand with no test cases. thoughts?

Changed 11 years ago by Adam Peller

Attachment: provider.patch​ added

general cleanup with proposed change to hasKey. need to build and test this

comment:2 Changed 11 years ago by guest

Excellent patch. It works well now. :)

comment:3 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [12017]) Fixes #5540, plus some style changes.

Note: See TracTickets for help on using tickets.