Opened 12 years ago

Closed 12 years ago

#5519 closed defect (fixed)

dojox.image.Lightbox infinite loading when image not loadable (404/403/etc.)

Reported by: guest Owned by: dante
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: dojox.image.Lightbox onerror Cc:
Blocked By: Blocking:

Description

In trunk-test_Lightbox.html the errors seem not to appear so far, should be tested further since I had some real odd event connection issues in Opera

Attachments (2)

Lightbox.patch​ (2.7 KB) - added by guest 12 years ago.
This patch uses warning.png as an image
warning.png​ (995 bytes) - added by guest 12 years ago.
this is a temporary warning png until I have made a larger one.. probable worth filing a ticket for that

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by dante

Owner: changed from Adam Peller to dante
Status: new → assigned

comment:2 Changed 12 years ago by Adam Peller

Cc: [email protected]… removed
Milestone: 1.0.3 → 1.1

comment:3 Changed 12 years ago by dante

nikolai,

thinking about this more, would it be possible to not add am image to the template, but to rather have an image node in the master dialog and onError, set the "main" image to the pre-cached, static "error.jpg" via imageNode.src

then, there would be no need for any additional logic, as setting the new source to a valid url would trigger the "natural" chain follow onLoad

comment:4 Changed 12 years ago by dante

(In [12080]) refs #5519 - adds broken link to test case

Changed 12 years ago by guest

Attachment: Lightbox.patch​ added

This patch uses warning.png as an image

Changed 12 years ago by guest

Attachment: warning.png​ added

this is a temporary warning png until I have made a larger one.. probable worth filing a ticket for that

comment:5 Changed 12 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [12081]) fixes #5519 - thanks nikolai - adds a default image for use when onload fails (404 on image), and continues normal operation.

Note: See TracTickets for help on using tickets.