Opened 12 years ago

Closed 7 years ago

#5509 closed defect (fixed)

popups/dnd placement off by a scrollbar width in themeTesterQuirk (IE6/7)

Reported by: Adam Peller Owned by: Adam Peller
Priority: low Milestone: 1.3.2
Component: HTML Version: 1.0
Keywords: bidi Cc: hwcdl@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

[11944] caused UT failure in IE6/7. Had to back out this line in _base/html.js 

+			return scrollLeft + de.clientWidth - de.scrollWidth; // Integer
-			return de.clientWidth - de.offsetWidth; // Integer

Now the unit tests pass again, but we're off by a scrollbar width.

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

(In [11955]) Fixes bidi in quirks mode (thanks, makin) Fixes #3721 and backs out change from [11944] Refs #5509. Plus some size reductions. !strict

comment:2 Changed 12 years ago by Adam Peller

Description: modified (diff)
Summary: [11944] caused UT failure in IE6/7 → popups/dnd placement off by a scrollbar width in themeTester

must have something to do with the fact that there's a scrollbar on a pane that's not the main document.

comment:3 Changed 11 years ago by Adam Peller

Milestone: 1.1 → 1.2

comment:4 Changed 11 years ago by Adam Peller

Description: modified (diff)
Milestone: 1.2 → 1.3

comment:5 Changed 11 years ago by Adam Peller

Milestone: 1.3 → future

comment:6 Changed 7 years ago by ben hockey

Keywords: needsreview added
Priority: high → low

i'm trying to identify stale tickets. if there is a need to keep this ticket open, please replace the "needsreview" keyword with "reviewed". if there is no need to keep this ticket open then please close it.

comment:7 Changed 7 years ago by Adam Peller

Keywords: needsreview removed
Resolution: → patchwelcome
Status: new → closed

comment:8 Changed 7 years ago by bill

Milestone: future
Resolution: patchwelcome
Status: closed → reopened
Summary: popups/dnd placement off by a scrollbar width in themeTester → popups/dnd placement off by a scrollbar width in themeTesterQuirk (IE6/7)

I reproduced this on 1.1/dijit/themes/themeTesterQuirk.html?dir=rtl, on IE8 in IE7-compat mode. looking at the "buttons" tab, and confirmed that it's fixed in 1.3.

comment:9 Changed 7 years ago by bill

Milestone: → 1.3.2
Resolution: → fixed
Status: reopened → closed
Note: See TracTickets for help on using tickets.