Opened 11 years ago

Closed 11 years ago

#5503 closed enhancement (fixed) markupFactory could use constructorFunction param

Reported by: guest Owned by: alex
Priority: high Milestone: 1.2
Component: DojoX Grid Version: 1.0
Keywords: Cc: juho.manninen@…
Blocked By: Blocking:

Description (last modified by sorvell)

Currently DojoData? class name is hard-coded in its markupFactory. This seems unnecessary and makes inheriting DojoData? class more complicated. There's an easy solution: the parser passes the current class to the markupFactory method. See http://localhost/dojo.ssh/dojox/grid/tests/test_tundra_edit.html for discussion.

Change History (4)

comment:1 Changed 11 years ago by sorvell

Description: modified (diff)
Milestone: 1.11.2
Owner: changed from sorvell to alex

So it looks like changing the markupFctory function in will work:

markupFactory: function(args, node, constructorFunction){
  return new constructorFunction(null, null, args);

Passing this to Alex to confirm and implement. Thanks.

comment:2 Changed 11 years ago by alex

perhaps more to the point in general we should be using more expressive markupFactory handlers for dojox.grid.*. I'll handle one for dojox.grid.Grid first and then do the DojoData? one second (although I hope we need that markupFactory less and less).

comment:3 Changed 11 years ago by alex

(In [12902]) add a new, greatly simplified, style of table construction from HTML tables and make working with stores stupidly easy. Event handlers aren't 100% and lots of stuff isn't fully configurable from the new table markup syntax just yet, but for getting someone started with the grid, this is the new hotness.

Refs #5503

comment:4 Changed 11 years ago by Bryan Forbes

Resolution: fixed
Status: newclosed

Fixed in [14193].

Note: See TracTickets for help on using tickets.