Opened 11 years ago

Closed 11 years ago

#5470 closed defect (wontfix)

_base/html.js strict errors

Reported by: tk Owned by: alex
Priority: high Milestone: 1.2
Component: Core Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Per Alex

svn: 'pre-commit' hook failed with error output: Error at dojo/trunk/_base/html.js:43 return statement is inconsistent with previous usage Error at dojo/trunk/_base/html.js:54 anonymous function does not always return a value Error at dojo/trunk/_base/html.js:595 TypeError?: redeclaration of var p. Error at dojo/trunk/_base/html.js:597 TypeError?: redeclaration of var be. Error at dojo/trunk/_base/html.js:624 Code has no side effects Error at dojo/trunk/_base/html.js:777 Code has no side effects Error at dojo/trunk/_base/html.js:926 TypeError?: redeclaration of var m. ERROR: Syntax errors. Checkin aborted. To override strict mode errors, use "!strict" in comment.

Change History (2)

comment:1 Changed 11 years ago by dylan

Milestone: 1.2

comment:2 Changed 11 years ago by Adam Peller

Resolution: wontfix
Status: newclosed

we've got these everywhere. we'll try to resolve the redeclarations as we hit them, but some of the other Rhino errors we're getting seem uninteresting or just bogus. If Rhino doesn't fix this, I might disable the strict hook (see #3970)

Note: See TracTickets for help on using tickets.