Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#547 closed defect (fixed)

TreeNode childIconSrc requests url()

Reported by: henrik@… Owned by: ilia
Priority: high Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

When the childIconSrc is not specified for treeNodes, the childIconSrc is set to the value "url()", This causes a request to the server, requesting the resource http://somewhere/folder/url(). I don't really understand what was the intention with the code, the childIcon.src property is already set to an empty graphic by the Tree method makeBlankImg(), and the display is set to none in the line after.

Before:

buildChildIcon: function() {
	this.childIcon.src = this.childIconSrc ? this.childIconSrc :"url()";
	this.childIcon.style.display = this.childIconSrc ? 'inline' : 'none';
},

After my changes:

buildChildIcon: function() {
	if (this.childIconSrc) { this.childIcon.src = this.childIconSrc	};
	this.childIcon.style.display = this.childIconSrc ? 'inline' : 'none';
},

Change History (4)

comment:1 Changed 14 years ago by bill

Owner: changed from anonymous to ilia

I think it used to be "" but we changed it to url() to workaround some problem, right Ilia?

comment:2 Changed 14 years ago by anonymous

Resolution: fixed
Status: newclosed

It now seems someone else has found this problem too, it was resolved in changeset 3387. /Henrik Hjelte

comment:3 Changed 14 years ago by alex

Milestone: 0.3release

comment:4 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.