dojo.isDescendant returns -1 on errors

[tk]

Per Adam, here's a ticket for this. dojo.isDescendant returns -1 if one of the args is invalid and causes an error. This breaks things like (dojo.isDescendant())?true:false since -1 will force this into the "true" branch.

this ticket refs #5425 (it is what caused that problem)

[Adam Peller]

This seems to stem from [10981]. Alex, was the return -1 intentional? It seems like we're better off letting the exception get squelched and just return false? I'd say we could just do an object check instead of the try/catch, but there's probably some browser quirk reason for doing so.

[Karl Tiedt]

(In [11922]) fixes #5464 - updating dojo.isDescendant to return false on error !strict

[Adam Peller]

sorry, but why return false if it's going to happen in the next line anyway?

[tk]

I spoke with Alex and that was the change that was discussed and ok'd.

[Adam Peller]

(In [11928]) so it seems right to revert this to [10980] unless there's a reason not to. Fixes #5464 !strict

[bill]

The -1 return code from dojo.isDescendant() is from [10981], to fix ​http://trac.dojotoolkit.org/ticket/4307#comment:8 (which was a show-stopper issue). It doesn't seem to be an issue anymore though, presumably because we stopped using tables in the input widget templates. Keep your fingers crossed.

[Adam Peller]

user reports that this prevented their tooltips from closing under certain situations. put fix in 1.0.x branch

[Adam Peller]

(In [11992]) Fixes #5464 !strict

[(none)]

Milestone 1.0.3 deleted