Opened 11 years ago

Closed 11 years ago

#5460 closed enhancement (fixed)

Make _Animation.fire private

Reported by: ptwobrussell Owned by: dante
Priority: high Milestone:
Component: fx Version: 1.0
Keywords: Cc: ptwobrussell@…, Bryan Forbes
Blocked By: Blocking:

Description

Again, documenting this based on a prior conversation with phiggins so that I can track the issue, or get some definitive guidance for the book I'm writing:

From our discussion, we thought that it might be wise to imply that fire is private by prefixing with an underscore because fire's entire purpose is to propagate the various synthetic events for the _Animation to act on. Doesn't seem that fire should be used publicly based on what it does and the other facilities that _Animation offers.

This might seem like a really big nit, but I've been looking at the breadth of the toolkit, Base and Core especially, from an API-centric standpoint and thought this was worth considering.

Attachments (1)

fx.patch (3.9 KB) - added by dante 11 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 11 years ago by Adam Peller

Cc: Bryan Forbes added

Changed 11 years ago by dante

Attachment: fx.patch added

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

(In [12110]) fixes #5460 - makes public method fire() private (_fire) because you should never ever call it. also changes the return value of stop() if called on a non-running animation, so if you were relying on undefined coming back, you can now reliablly chain .status() on .stop() instead ... fixes #5611 - some d = dojo love cleanups included !strict

Note: See TracTickets for help on using tickets.