Opened 11 years ago

Closed 11 years ago

#5443 closed defect (fixed)

span vs div in dijit._Calendar

Reported by: guest Owned by: Adam Peller
Priority: low Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: calendar css Cc:
Blocked By: Blocking:

Description

The template markup for dijit._Calendar currently reads (extra cr's added): 

<th class='dijitReset' dojoAttachPoint="decrementMonth">
    <span class="dijitInline dijitCalendarIncrementControl dijitCalendarDecrease">
        <span dojoAttachPoint="decreaseArrowNode" class="dijitA11ySideArrow dijitCalendarIncrementControl dijitCalendarDecreaseInner">-</span>
    </span>
</th>

However the other two th's have divs as their children and spans therein.

Only noticed because my alternate CSS throws a wobbly due to the span being an inline element. Tundra doesn't have a problem because it would seem that the standard image fits within the span, while mine does not.

Adding display: block; to .tundra .dijitCalendarDecrease takes care of the issue, but it I don't think it should be in the first place.

See mbowie in #dojo with any q's.

Change History (2)

comment:1 Changed 11 years ago by Adam Peller

Milestone: 1.0.3 → 1.1
Owner: set to Adam Peller
Status: new → assigned

comment:2 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: assigned → closed

(In [11896]) Fixes #5443, at least we have symmetry. Not sure why it matters whether they're divs or spans (see r9976)

Note: See TracTickets for help on using tickets.