Opened 12 years ago

Closed 12 years ago

#5437 closed defect (fixed)

CSS Sprite for Tundra Theme

Reported by: daniel.carrera@… Owned by: dante
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: enhancement Cc:
Blocked By: Blocking:

Description (last modified by dante)

It'd be nice if Tundra combined images together (e.g. the 6 tree images) to avoid multiple HTTP requests (CSS Sprite tutorial). I have a tundra-derived theme that does a CSS Sprite for the tree images, arrow images and buttons. I thought I'd submit my files and patch in case anyone is interested.

Limitations: Not throughly tested. Does not include tabs or RTL. Those shouldn't be hard to add, if the basic idea works and is accepted.

Attachments (2)

images.zip (5.6 KB) - added by guest 12 years ago.
New (combined) images.
patch.txt (5.2 KB) - added by guest 12 years ago.
Patch to tundra.css

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Attachment: images.zip added

New (combined) images.

Changed 12 years ago by guest

Attachment: patch.txt added

Patch to tundra.css

comment:1 Changed 12 years ago by bill

Cc: daniel.carrera@… removed
Reporter: changed from guest to daniel.carrera@…

Hi. Thanks for the patch. We definitely want to do this. Your patch looks a bit out of date though. Tundra changed after the 1.0 release, and with the latest tundra (in trunk) I think everything is just gif files, plus we have more tree images (we have folders icons now).

But if you want to sprite-ify the latest stuff that would be great. (Should sign a CLA though, if you haven't already.)

comment:2 Changed 12 years ago by bill

Component: GeneralDijit
Owner: anonymous deleted

comment:3 Changed 12 years ago by dante

refs #4114 ... I can work with daniel on this if he's interested in doing this in trunk. keep in mind, in tundra, some images can't be sprites (if they have to repeat in a direction) ... also they need an accompanying gif if they make use of alpha at all.

can assign to me if you like.

comment:4 Changed 12 years ago by guest

:-(

Ok, I'm willing to do this again with the new Tundra in trunk. Yes, I've signed the CLA. I'll do that tomorrow or Sunday. Maybe just the tree widget and see how that looks.

Dante: Could you send me an email so I know your email?

comment:5 Changed 12 years ago by bill

Milestone: 1.2
Owner: set to dante

comment:6 Changed 12 years ago by dante

Description: modified (diff)
Resolution: fixed
Status: newclosed

This patch it out of date as it stands. Bill: closing this ticket out for now. feel free to open more specific "needs a sprite" tickets as necessary, as I know you've been doing stuff towards this already.

Note: See TracTickets for help on using tickets.