Opened 13 years ago
Closed 9 years ago
#5436 closed defect (wontfix)
ShrinkSafe appears to not handle '$super' in this code
Reported by: | guest | Owned by: | Richard Backhouse |
---|---|---|---|
Priority: | high | Milestone: | future |
Component: | ShrinkSafe | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Sorry, I'm not a javascript expert. But I wanted to use Prototype (http://www.prototypejs.org) to do some Ajax in my web application. The uncompressed version seems to work fine, but the compressed version gives error "_13a is not a function" for line:
Ajax.PeriodicalUpdater=Class.create(Ajax.Base,{initialize:function(_13a,_13b,url,_13d){ _13a(_13d); // <<< error here this.onComplete=this.options.onComplete;
The uncompressed version is:
Ajax.PeriodicalUpdater = Class.create(Ajax.Base, { initialize: function($super, container, url, options) { $super(options); this.onComplete = this.options.onComplete;
Thanks.
Change History (8)
comment:1 Changed 13 years ago by
Component: | General → ShrinkSafe |
---|---|
Description: | modified (diff) |
Owner: | changed from anonymous to alex |
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Milestone: | → 1.3 |
---|
comment:4 Changed 13 years ago by
you can find more info at http://ajax.sys-con.com/read/464826.htm
comment:5 Changed 13 years ago by
Description: | modified (diff) |
---|
thanks for the ref... has nothing to do with the snippets, per se. Our options? We could 'whitelist' variables starting with "$" from shrinksafe, provide some other whitelist mechanism, either one is pretty fragile or just say that we don't support this scenario; it's a slippery slope once you start depending on variable names.
comment:6 Changed 12 years ago by
Milestone: | 1.3 → future |
---|
comment:7 Changed 11 years ago by
Owner: | changed from alex to Richard Backhouse |
---|
comment:8 Changed 9 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I'm going to go with "we don't support this scenario"
might need a complete example to see what's going on here (please use attach file)