Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5415 closed defect (fixed)

correction of [11732]

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Core Version: 1.0
Keywords: xhr objectToQuery Cc:
Blocked By: Blocking:

Description

There is a little bug introduced in [11732], in xhr.js (objectToQuery). The bug is that if I have a form input with a name containing encodeable charcters, they won't be sent. This is because of the line 105: name=enc(name), followed by the line var value=map[name]. In order to make this working, you have to encode the name after retrieving the value, or it won't find anything in the map.

I attach a patch to this request, but it's really nothing, just swap these two lines.

Attachments (1)

xhr.patch​ (407 bytes) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by guest

Attachment: xhr.patch​ added

comment:1 Changed 12 years ago by bill

Owner: changed from anonymous to Adam Peller

comment:2 Changed 12 years ago by Adam Peller

Milestone: 1.0.3 → 1.1

thanks for picking up on this

comment:3 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [11860]) repair encoding regression in [11732] and add test cases. Fixes #5415

comment:4 Changed 12 years ago by Adam Peller

(In [11861]) Fix unresolved reference 'url'. Refs #5415

Note: See TracTickets for help on using tickets.