Opened 12 years ago

Closed 9 years ago

#5381 closed defect (fixed)

test file labels appear on wrong side in RTL mode

Reported by: bill Owned by: bill
Priority: low Milestone: 1.6
Component: Dijit Version: 0.9
Keywords: bidi Cc: hwcdl@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

See http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_ComboBox.html?dir=rtl

The labels are appearing on the left of the inputs rather than the right, like they should (IIUC). See "US State Test" label for an example. Compare with the form at the bottom of https://www.cal-online.co.il/he-IL/cal/Active/Pages/welcome.aspx

Probably a test file problem although I'm not sure what. Would be nice (but not essential) if our test file boilerplate text looked correct in RTL mode.

Happens at least on Safari and FF3.

Change History (5)

comment:1 Changed 12 years ago by Adam Peller

Cc: hwcdl@… added
Keywords: bidi added

comment:2 Changed 12 years ago by alex

Milestone: 2.01.3

Milestone 2.0 deleted

comment:3 Changed 11 years ago by Adam Peller

Description: modified (diff)
Milestone: 1.3future

comment:4 Changed 9 years ago by bill

Milestone: future1.6
Owner: changed from Adam Peller to bill
Status: newassigned

I mainly fixed this in [22739], for #11041, although the ComboBox test file also needs to be updated since it's got stray text outside of the labels.

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22748]) Put all of the label text inside of the <label>, so that it appears correctly in RTL mode. Fixes #5381, refs #11041.

Note: See TracTickets for help on using tickets.