[patch][cla]Difficult to set float with dojo.style

[guest]

To set a node's float, you have to do something like:

dojo.style(node, dojo.isIE ? "styleFloat" : "cssFloat", "right");

It would be nice if you could simply do:

dojo.style(node, "float", "right");

and have Dojo take care of the browser check.

"styleFloat" works in IE and Opera, "cssFloat" works in Mozilla, Safari, and Opera.

[dante]

first line of dojo.style function:

style = (style == "float" ? (dojo.isIE ? "styleFloat" : "cssFloat") : style);

seems like a fix.

[dante]

proposed fix. tested manually in FF2 + IE7

[alex]

wait, I though we'd merged this? It really isn't landing for 1.1?

[Adam Peller]

should we use "cssFloat" instead of "float", if that's what most browsers do?

[sjmiles]

Here is my proposed fix. I didn't commit it because I have not had time to write a unit test. If any of you guys want to commit this, or dante's version, it's ok with me.

above dojo.style:

	var _floatStyle = dojo.isIE ? "styleFloat" : "cssFloat";
	var _floatAliases = { "cssFloat": _floatStyle, "styleFloat": _floatStyle, "float": _floatStyle };

inside dojo.style:

	style = _floatAliases[style] || style;

Attached.

[sjmiles]

Possible alternate patch, see comment.

[dante]

+1 from me. that means "float":"left", "cssFloat":"left" and styleFloat:"left" all will work. and compresses slightly better. go sjmiles.

[sjmiles]

(In [12934]) Fixes #5372. !strict