#5357 closed defect (fixed)
ItemFileWriteStore does not revert properly
| Reported by: | guest | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0.2 |
| Component: | Data | Version: | 1.0 |
| Keywords: | ItemFileWriteStore revert | Cc: | |
| Blocked By: | Blocking: |
Description
When items are added there is a
newItem[this._itemNumPropName]=this._arrayOfAllItems.length and then this_arrayOfAllItems.push(newItem).
On the revert it does
this._arrayOfAllItems[newItem._itemNumPropName]=null.
It should be this._arrayOfAllItems[newItem[this._itemNumPropName]].
JavaScript? in its wisdom is failing silently here since newItem has no _itemNumPropName. It is also clear that the functionality was never tested when the method was changed for version 1.0. Include a test case with the fix!
Attachments (1)
Change History (5)
Changed 12 years ago by
| Attachment: | dojo.data.ItemFileWriteStore_20071213.patch added |
|---|
comment:1 Changed 12 years ago by
Tested on: FireFox? 2.0.0.11 IE 6 Safari B3 Opera 9.2 SeaMonkey? 1.1.2
comment:2 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 12 years ago by
| Milestone: | → 1.0.3 |
|---|
comment:4 Changed 12 years ago by
| Milestone: | 1.0.3 → 1.0.2 |
|---|
Note: See
TracTickets for help on using
tickets.
Patch for this + UT.