Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5351 closed defect (fixed)

destroy dialog fails to disconnect its modal intercepts

Reported by: Dustin Machi Owned by: dante
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Certain keys will fail to work if you destroy() a dialog instead of or without hide()ing it first. Making sure to hide() it first, ensures _modalConnects are disconnected, so they dont' get lost when the widget is destroy()d

Attachments (4)

DialogDestroy.patch​ (394 bytes) - added by dante 11 years ago.
fix
dialog.patch​ (1.1 KB) - added by dante 11 years ago.
updated patch takes more into consideration
tryMe.patch​ (1.3 KB) - added by dante 11 years ago.
and the winner is …
5351.diff​ (1.2 KB) - added by Bryan Forbes 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by dante

Owner: set to dante
Status: new → assigned

Changed 11 years ago by dante

Attachment: DialogDestroy.patch​ added

fix

Changed 11 years ago by dante

Attachment: dialog.patch​ added

updated patch takes more into consideration

Changed 11 years ago by dante

Attachment: tryMe.patch​ added

and the winner is ...

Changed 11 years ago by Bryan Forbes

Attachment: 5351.diff​ added

comment:2 Changed 11 years ago by dante

(In [12065]) refs #5351 - test case for focus, and keyboard events.

comment:3 Changed 11 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [12068]) fixes #5351 - modal connects not being disconnected in a lot of destroy/hide combinations. accomodates focus state, but simply destroy's the underlay and bgiframe etc.

comment:4 Changed 11 years ago by bill

(In [13106]) Fix link in test; refs #5351.

Note: See TracTickets for help on using tickets.