dojox.grid declares dojo function unknowingly

[dante]

in dojox/grid/_grid/lib.js the function dojo.isNumber is defined. this is technically not allowed, and is a simple fix as a call to dojo.isNumber only appears ~ line 50 or dojox/grid/_grid/view.js in the setStructure() method.

it is an issue because the doc tool picks up the fact you are given a dojo.isNumber method by calling dojo.require("dojox.grid._grid.lib") which is just weird.

[dante]

actually, the comments in view.js say "similar logic is duplicated in layout", and it is in addCellDef() ... that particular method uses (!isNaN(foo))) vs's the problematic dojo.isNumber(foo) method used in view.js

[dante]

cleaner patch going isNaN route

[dante]

attached a patch removing dojo.isNumber = function ... and duplicating method found in _grid/layout.js !isNaN(...) deferring to you for consideration or to make a decision about making isNumber a private function somewhere within dojox.grid if it's vital that 0 not return false ... either way, they should have the same behavior or even share code (the parent methods mentioned)

[sorvell]

Closing this bug. The change to use isNaN was made in [10734] and is reasonable.

[dante]

actually was fixed in [11983] fwiw