Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#5322 closed defect (fixed)

Widgets render taller in IE (ComboBox,TextArea,TitlePane)

Reported by: guest Owned by: Douglas Hays
Priority: low Milestone: 1.1
Component: Dijit - Form Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

IE7 renders the ComboBox?, empty TextArea?, and TitlePane? widgets at about twice the height that they should be. Firefox is fine. This may be a problem with the tundra theme.

Related bug: #5236

Attachments (1)

combo.png (3.0 KB) - added by guest 12 years ago.
Shows ComboBox? in error state rendered in IE7

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by guest

Attachment: combo.png added

Shows ComboBox? in error state rendered in IE7

comment:1 Changed 12 years ago by guest

I think the double height in the ComboBox? may be due to that X bellow the warning image that can be seen in the combo.png attachment.

comment:2 Changed 12 years ago by bill

That X is for accessibility mode, when background-images are turned off so we print an X character instead, but it shouldn't be showing up for you. See http://download.dojotoolkit.org/release-1.0.1/dojo-release-1.0.1/dijit/tests/form/test_ComboBox.html

Can you attach a testcase? And also compare against that test above to see why it's working and your test is failing. Perhaps there's some race condition loading CSS? What if you move your CSS load to the very first thing in your file?

comment:3 Changed 12 years ago by guest

When I attempted to isolate my test case the extracted html rendered correctly in IE. So the ComboBox? issue is my fault.

However, the other two widgets definitely have problems with their test cases. If you look at the test_Textarea or test_TitlePane pages you'll notice extra height in the widgets within Internet Explorer. I've tested with IE7 and am not certain if the problem exists in IE6.

comment:4 Changed 12 years ago by bill

The TitlePane? problem is being handled in #5236.

As for TextArea?, that's an artifact of using an iframe in IE and each line of text being treated as a paragraph rather than just having <br> between them. It's just how IE works. But would be handled by using a normal textarea, see #4979 (which I'd be willing to do if the code turns out reasonable, even though I closed the defect).

comment:5 Changed 12 years ago by bill

Hmm, my last comment had an error. IE uses a <div>, not an <iframe>. But each "line in the TextArea?" is really a separate <p>, and that's why there is extra spacing. Maybe we need CSS to make paragraph-spacing 0 (but just inside that div, not on the whole page).

comment:6 Changed 12 years ago by bill

Milestone: 1.0.21.1
Owner: set to Douglas Hays

The ComboBox? fix is too complex to risk on the 1.0 branch. The TitlePane? fix could be added. As for TextArea?, it's just CSS, but we can defer till 1.1 because it's not a critical issue.

comment:7 Changed 12 years ago by dante

(In [11787]) refs #5322 - fixes one aspect of ticket targeted at 1.0 branch, refs #5236 - a ticket describing the titlepane issue this fixes, the dup part of #5322

comment:8 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

TextArea? fixed in [11994].

comment:9 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.