Opened 12 years ago

Closed 12 years ago

#5321 closed defect (fixed)

dijit.Menu does not pass any args to dijit.MenuItem.onClick

Reported by: tk Owned by:
Priority: high Milestone: 1.0.2
Component: Dijit Version: 1.0
Keywords: dijit.Menu dijit.MenuItem Cc:
Blocked By: Blocking:

Description

Should dijit.Menu's onItemClick function pass the item back to dijit.MenuItem?'s onClick handler so users can intercept it?

Its a small fix, if this is acceptable I can commit the change.

Change History (2)

comment:1 Changed 12 years ago by bill

You should pass the event object, not a pointer to the MenuItem?. That's consistent with dijit.form.Button and other widgets.

Perhaps all widgets should be passing a pointer back to themselves but it's currently not done.

comment:2 Changed 12 years ago by Karl Tiedt

Resolution: fixed
Status: newclosed

(In [11744]) fixes #5321 changed onItemClick api by adding the event object from the menuItems _onClick handler so that it can be passed back to the menuItems onClick handler that users connect to/overide.

added brief summary for dijit.Menu as well.

Note: See TracTickets for help on using tickets.