#5307 closed defect (fixed)
[patch] ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress
| Reported by: | nathan | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Data | Version: | 0.9 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
If you call fetchItemByIdentity quickly twice in succession, then you will get two xhr get requests, because the _loadInProgress flag is not getting set in that function (it gets set in fetch, and it gets properly unset)
A testcase and patch will follow.
Attachments (3)
Change History (8)
Changed 12 years ago by
| Attachment: | testcase-5307.html added |
|---|
comment:1 Changed 12 years ago by
Running the test case, you will see (using the debug log in firebug) that there is only one request made when test1 is run, but 2 requests are made when test2 is run.
After applying the patch, only one request is made in both cases.
comment:2 Changed 12 years ago by
| Component: | General → Data |
|---|---|
| Owner: | changed from anonymous to Jared Jurkiewicz |
| Summary: | ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress → [patch] ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress |
comment:3 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 12 years ago by
| Cc: | nathan added; [email protected]… removed |
|---|
comment:5 Changed 12 years ago by
| Cc: | nathan removed |
|---|---|
| Reporter: | changed from guest to nathan |
Note: See
TracTickets for help on using
tickets.
Test case for ticket 5307