Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5307 closed defect (fixed)

[patch] ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress

Reported by: nathan Owned by: Jared Jurkiewicz
Priority: high Milestone:
Component: Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

If you call fetchItemByIdentity quickly twice in succession, then you will get two xhr get requests, because the _loadInProgress flag is not getting set in that function (it gets set in fetch, and it gets properly unset)

A testcase and patch will follow.

Attachments (3)

testcase-5307.html (1.4 KB) - added by guest 12 years ago.
Test case for ticket 5307
data-5307.json (142 bytes) - added by guest 12 years ago.
Data for test case
patch-5307.diff (436 bytes) - added by guest 12 years ago.
Patch to fix ItemFileReadStore?

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Attachment: testcase-5307.html added

Test case for ticket 5307

Changed 12 years ago by guest

Attachment: data-5307.json added

Data for test case

Changed 12 years ago by guest

Attachment: patch-5307.diff added

Patch to fix ItemFileReadStore?

comment:1 Changed 12 years ago by guest

Running the test case, you will see (using the debug log in firebug) that there is only one request made when test1 is run, but 2 requests are made when test2 is run.

After applying the patch, only one request is made in both cases.

comment:2 Changed 12 years ago by bill

Component: GeneralData
Owner: changed from anonymous to Jared Jurkiewicz
Summary: ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress[patch] ItemFileReadStore's fetchItemByIdentity function doesn't set _loadInProgress

comment:3 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [11708]) Minor patch. fixes #5307

comment:4 Changed 12 years ago by nathan

Cc: nathan added; nathan@… removed

comment:5 Changed 12 years ago by nathan

Cc: nathan removed
Reporter: changed from guest to nathan
Note: See TracTickets for help on using tickets.