Opened 12 years ago

Closed 8 years ago

#5289 closed defect (fixed)

Editor: setting background color while no text selected has no effect

Reported by: guest Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.7
Component: Editor Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

If no text is selected and a background color is chosen, typing does not get colored. It ought to, just as it does with the foreground color. Also the selected color for either plugin should stay selected, that is the button ought to stay depressed (toggle) until it is pressed again. Or at least this should be settable behavior through some argument to the plugin. Also, we suggest, that the selected color might be used to color the button background color and that the icon be transparent to let the color so the user can see what color is selected.

Change History (11)

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.0.21.1

looks like some browser quirks we should try to normalize, if we can: when there's no selection, Safari disables the background color, FF ignores it, and IE colors the entire word. The easy way out would be to disable the command whenever there is no selection for all browsers.

The color toolbar icon overlay is a nice idea for an enhancement, but right now I don't think we convey the current selection state at all in the color picker, which would also be nice. These are all separate issues.

comment:2 in reply to:  1 Changed 12 years ago by jeffg

Just to clarify, when a foreground color is selected it ought to become and remain the current color used for all subsequent typing. And the background color ought to behave the same.

Then there's the question of what to do when the user selects text. For my use case, I don't want selection to affect the ability of the user to select the foreground/background text color. So I say, do nothing in the case of selection.

comment:3 Changed 11 years ago by alex

Owner: changed from liucougar to alex
Status: newassigned

comment:4 Changed 11 years ago by dylan

mass move of editor issues to 1.2.

comment:5 Changed 11 years ago by dylan

Milestone: 1.11.2

comment:6 Changed 11 years ago by bill

Description: modified (diff)
Milestone: 1.21.3

comment:7 Changed 11 years ago by bill

Milestone: 1.3future

comment:8 Changed 9 years ago by Adam Peller

Owner: changed from alex to jared
Status: assignednew

comment:9 Changed 9 years ago by Douglas Hays

Owner: changed from jared to Jared Jurkiewicz

comment:10 Changed 9 years ago by bill

Summary: Editor foreground and background color plugins don't operate correctlyEditor: setting background color while no text selected has no effect

I just tried in trunk on FF3.6/mac. The foreground button was working but not the background button. It might depend on where the caret is too, not sure.

comment:11 Changed 8 years ago by Jared Jurkiewicz

Milestone: future1.7
Resolution: fixed
Status: newclosed

Fixed in: [25599]

Note: See TracTickets for help on using tickets.