Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#5285 closed defect (fixed)

Dialog: jumps around while dragging (FF/linux)

Reported by: guest Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit Version: 1.0
Keywords: Cc: Douglas Hays, Eugene Lazutkin
Blocked By: Blocking:

Description (last modified by bill)

Opening http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Dialog.html in Linux using Firefox 2.0.9, and clicking Show Dialog shows a Dialog. Trying to move it around the screen results in Dialog chaotically jumping around.

Change History (26)

comment:1 Changed 12 years ago by dante

Component: GeneralDijit
Owner: anonymous deleted
Summary: Dialog jumps around while draggingdijit.Dialog jumps around while dragging

comment:2 Changed 12 years ago by bill

Is this only a problem on Linux? I've tried FF2 on PC and mac and see no problem. The dialog is a bit jumpy in movement but I wouldn't call it chaotic. Just has a bit of a lag.

comment:3 Changed 12 years ago by dante

afaik, yes. linux FF only.

comment:4 Changed 12 years ago by guest

I'm on Ubuntu and I use Firefox 2.0.0.11 and I've also this issue.

comment:5 Changed 12 years ago by guest

There are also this issue on Firefox 3.0 alpha 8.

comment:6 Changed 12 years ago by bill

OK, I don't have any variant of UNIX (besides the mac), so one of you is going to need to debug this. If there's an issue with Dialog itself I can give you advice, although probably it's just an issue with DnD itself; you might want to try some of the plain DnD tests to see if they work.

comment:7 Changed 12 years ago by guest

dojo/tests/dnd/test_moveable.html works very well on Ubuntu Firefox 2

comment:8 Changed 12 years ago by alex

Milestone: 1.1
Owner: set to alex
Status: newassigned

comment:9 Changed 12 years ago by guest

I've found problem origin :

In dijit.css at

.dijitContentPane {

display: block; overflow: auto; /* if we don't have this (or overflow:hidden), then Widget.resizeTo() doesn't make sense for ContentPane? */

}

if I remove "overflow: auto" then dijit.Dialog move very well.

I don't know how fix it cleanly.

comment:10 Changed 11 years ago by Douglas Hays

Cc: Douglas Hays added

See also #5562

comment:11 Changed 11 years ago by bill

Summary: dijit.Dialog jumps around while draggingdijit.Dialog jumps around while dragging (FF/linux)

I don't know why that overflow: auto rule is there to begin with, since overflow: auto is the default for <divs>. So it's probably OK to remove it but need to make sure that other widgets like Accordion or TabContainer? don't break (ie, make sure that a scrollbar appears when necessary)

Note also that Dialog in 0.9 is different than Dialog in 0.4, because the Dialog in 0.4 has a specified width/height (ex: style="width: 300px; height: 300px'") whereas 0.9 forwards, the height is just determined by the content, just like a plain <div> w/no specified style. Perhaps setting the height/width while dragging would help.

comment:12 Changed 11 years ago by dylan

I believe it is there for the Firefox 2 bug where the cursor gets hidden in form fields... it's deliberately there.

comment:13 Changed 11 years ago by dylan

By the way, I was referring to the fix for #1417

comment:14 Changed 11 years ago by Douglas Hays

Please re-evaluate this ticket's problem using the dojo trunk with revision [12805]. IE dragging was also jumping/lagging and that is now performing better.

comment:15 Changed 11 years ago by guest

Trying on the nightly link now works for me in FF2!

Thanks!

David Snopek (http://www.hackyourlife.org/)

comment:16 Changed 11 years ago by Douglas Hays

Let's leave this defect open for now since we may want to back out the fix from dojo core and put it in dijit instead.

comment:17 Changed 11 years ago by Douglas Hays

Cc: Eugene Lazutkin added

comment:18 Changed 11 years ago by Douglas Hays

Owner: changed from alex to Douglas Hays
Status: assignednew

comment:19 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [13014]) Fixes #5285, #6138. Change Dialog to use the new TimedMoveable? code.

comment:20 Changed 11 years ago by bill

Description: modified (diff)

Regarding the overflow:auto, see #6350. It's there for ContentPane on-purpose (although it's debatable), but we could add an overriding rule for Dialog (and other widgets that derive from ContentPane) if necessary.

comment:21 Changed 11 years ago by bill

(In [14913]) Remove overflow: hidden from Dialog. Although it makes dragging smoother on FF2/linux, it causes a disappearing cursor problem on FF2. The bad outweighs the good. Fixes #7408, refs #5285.

comment:22 Changed 11 years ago by ergo

Resolution: fixed
Status: closedreopened

The problem still exists tested on: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1

last build that act fine (but slow) 2008-08-19 2008-08-20 - problems start from here on

comment:23 Changed 11 years ago by bill

Milestone: 1.11.3
Summary: dijit.Dialog jumps around while dragging (FF/linux)Dialog: jumps around while dragging (FF/linux)

Yes, as per [14913] this is an expected problem (it should still be usable, just jumpy). Is it unusable for you?

You could try adding rules like:

.dijitDialog {
     overflow: hidden;       /* override overflow: auto; from ContentPane to make dragging smoother */
}
.dj_ff2 .dijitDialog {
     overflow: auto;          /* avoid disappearing cursor problem, see http://bugs.dojotoolkit.org/ticket/7408 */
}

comment:24 Changed 11 years ago by Douglas Hays

Owner: changed from Douglas Hays to bill
Status: reopenednew

I recommend adding the above css rules to dijit.css

comment:25 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [15984]) Fix jumpy dialog dragging on linux. Fixes #5285.

comment:26 Changed 8 years ago by liucougar

In [26165]:

refs #5285: remove timeout argument for Moveable, and consolidate creation of Moveable

!strict

Note: See TracTickets for help on using tickets.