Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5273 closed defect (fixed)

Using optimize=shrinksafe results in some scary (non-fatal) errors

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.0.2
Component: BuildSystem Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

You will see the following:

[java] release: Interning strings for: ../../release/dojo/dijit [java] release: Interning strings for: ../../release/dojo/dojox [java] release: Interning strings for: ../../release/dojo/dojo [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 3: missing ) in parenthetical [java] js: ["require", moduleName + ".nls" + (bestLocale ? "." + bestLocale : ""]], [java] js: ................................................................ ..... [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 4: syntax error [java] js: defineResource: function(dojo){if(!dojo._hasResource["dojo._base ._loader.loader_xd"]){ _hasResource checks added by build. Do not use _hasReso urce directly in your code. [java] releasehttp://www.dojotoolkit.org/forum/dojo-core-dojo-0-9/dojo-core-support/dojo-custom-build-subdomain-hosting# Enable rich text editor: Could not strip comments for file: ../../release/dojo/dojo /_base/_loader/loader_xd.xd.js, error: InternalError?: Compilation produced 5 syn tax errors. (../../release/dojo/dojo/_base/_loader/loader_xd.xd.js#1) [java] js: ............... [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 5: syntax error [java] js: dojo._hasResourcedojo._base._loader.loader_xd? = true; [java] js: ..... [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 63 2: syntax error [java] js: } [java] js: [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 63 4: syntax error [java] js: }}); [java] js: . [java] js: "../../release/dojo/dojo/_base/_loader/loader_xd.xd.js", line 1: Compilation produced 5 syntax errors. [java] release: Build is in directory: ../../release/dojo

We should either avoid processing loader_xd.js for xdomain tranformation (into an xd.js file) or skip the file during optimization.

Change History (2)

comment:1 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [11781]) Fixes #5273: xd-processing the _loader/loader_xd.js file was causing an error when the resulting (invalid) javascript is processed. There is a larger issue with dojo.require dependency parsing (picks up funky concatenated strings, but the result is invalid). However, that should be addressed by #2766 in 1.1.

comment:2 Changed 11 years ago by James Burke

(In [11782]) Fixes #5273: xd-processing the _loader/loader_xd.js file was causing an error when the resulting (invalid) javascript is processed. There is a larger issue with dojo.require dependency parsing (picks up funky concatenated strings, but the result is invalid). However, that should be addressed by #2766 in 1.1. (merge to trunk)

Note: See TracTickets for help on using tickets.